Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LoggingConfigurationParser - Fixed bug in handling of extensions prefix #3199

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 25, 2019

Not sure why this bug was introduced. Maybe I was testing a solution for #2944

@snakefoot snakefoot force-pushed the ConfigParserTypeInvalidStrip branch from 1ea1bed to 2fee607 Compare March 25, 2019 20:30
@304NotModified 304NotModified added bug Bug report / Bug fix nlog-configuration labels Mar 25, 2019
@304NotModified 304NotModified added this to the 4.6.1 milestone Mar 25, 2019
Copy link
Member

@304NotModified 304NotModified left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #3199 into dev will increase coverage by <1%.
The diff coverage is 87%.

@@          Coverage Diff           @@
##             dev   #3199    +/-   ##
======================================
+ Coverage     80%     80%   +<1%     
======================================
  Files        354     354            
  Lines      27909   27911     +2     
  Branches    3706    3706            
======================================
+ Hits       22241   22270    +29     
+ Misses      4599    4575    -24     
+ Partials    1069    1066     -3

@304NotModified 304NotModified merged commit 66c2118 into NLog:dev Mar 25, 2019
@snakefoot snakefoot deleted the ConfigParserTypeInvalidStrip branch April 4, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix nlog-configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants