Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VariableLayoutRenderer - Fixed typo in internal logger warning message #3191

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

snakefoot
Copy link
Contributor

When not threadsafe. Resolves #3190

@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #3191 into dev will decrease coverage by <1%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             dev   #3191    +/-   ##
======================================
- Coverage     80%     80%   -<1%     
======================================
  Files        354     354            
  Lines      27909   27909            
  Branches    3706    3706            
======================================
- Hits       22251   22235    -16     
- Misses      4597    4611    +14     
- Partials    1061    1063     +2

1 similar comment
@codecov
Copy link

codecov bot commented Mar 23, 2019

Codecov Report

Merging #3191 into dev will decrease coverage by <1%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##             dev   #3191    +/-   ##
======================================
- Coverage     80%     80%   -<1%     
======================================
  Files        354     354            
  Lines      27909   27909            
  Branches    3706    3706            
======================================
- Hits       22251   22235    -16     
- Misses      4597    4611    +14     
- Partials    1061    1063     +2

@304NotModified
Copy link
Member

Thanks!

@304NotModified 304NotModified added this to the 4.6.1 milestone Mar 24, 2019
@304NotModified 304NotModified added the enhancement Improvement on existing feature label Mar 24, 2019
@304NotModified 304NotModified merged commit 7aa7ba7 into NLog:dev Mar 24, 2019
@snakefoot
Copy link
Contributor Author

@304NotModified Think this is more of a "bug" than an "enhancement".

@304NotModified 304NotModified added bug Bug report / Bug fix and removed enhancement Improvement on existing feature labels Mar 27, 2019
@304NotModified 304NotModified changed the title VariableLayoutRenderer - Fixed format-string for internal logger warning VariableLayoutRenderer - Fixed internal logger warning typo Mar 27, 2019
@304NotModified
Copy link
Member

OK, changed it 👍

@304NotModified 304NotModified changed the title VariableLayoutRenderer - Fixed internal logger warning typo VariableLayoutRenderer - Fixed typo in internal logger warning message Mar 27, 2019
@snakefoot snakefoot deleted the VariableLayoutRendererThreadSafe branch April 4, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report / Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants