Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit test added for Variable node #1173

Conversation

UgurAldanmaz
Copy link
Contributor

This unit test is testing the thrown exception is
NLogConfigurationException or not when variable node is written to wrong
place.

For #1128

Configuration validation will be done at #1174

This unit test is testing the thrown exception is
NLogConfigurationException or not when variable node is written to wrong
place.
@codecov-io
Copy link

Current coverage is 73.54%

Merging #1173 into master will decrease coverage by -0.08% as of 7c4cea4

@@            master   #1173   diff @@
======================================
  Files          265     265       
  Stmts        15057   15057       
  Branches      1651    1652     +1
  Methods          0       0       
======================================
- Hit          11086   11073    -13
- Partial        417     420     +3
- Missed        3554    3564    +10

Review entire Coverage Diff as of 7c4cea4


Uncovered Suggestions

  1. +0.08% via ...nternal/AspHelper.cs#206...218
  2. +0.08% via ...nternal/AspHelper.cs#188...200
  3. +0.08% via ...nternal/AspHelper.cs#170...182
  4. See 7 more...

Powered by Codecov. Updated on successful CI builds.

@304NotModified
Copy link
Member

Thanks! Can you also make a variant where the <variable> is after the <target>?

@s-sreenath
Copy link
Contributor

Thanks! Can you also make a variant where the is after the ?

+1

@UgurAldanmaz
Copy link
Contributor Author

Sure. I made it using InlineData and Theory :)

@UgurAldanmaz
Copy link
Contributor Author

There are problems with Mono reference and Theory attribute (for Silverlight).

I am going to remove Theory attribute but I am not sure about Mono error. It is not related to this commit.

@s-sreenath
Copy link
Contributor

@UgurAldanmaz may be you just need to surround with conditional statements.

Uğur Aldanmaz added 2 commits January 18, 2016 00:25
Because of lack of Silverlight supporting.
@304NotModified
Copy link
Member

Fixes #1128

@304NotModified 304NotModified added enhancement Improvement on existing feature has unittests and removed in-review labels Jan 18, 2016
304NotModified added a commit that referenced this pull request Jan 18, 2016
…ts-for-wrong-variable-node-placement

Unit test added for Variable node
@304NotModified 304NotModified merged commit 85abc93 into NLog:master Jan 18, 2016
@304NotModified
Copy link
Member

Thanks! It had been merged!

@UgurAldanmaz
Copy link
Contributor Author

Thanks! I am closing related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement on existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants