LogFactory - GetLogger should validate name of logger (#3332)

NLog · Apr 24, 2019 · ea6f665 · ea6f665
1 parent 3c16e69
commit ea6f665
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/src/NLog/LogFactory.cs b/src/NLog/LogFactory.cs
@@ -889,6 +889,9 @@ public void ResetCandidateConfigFilePath()
 
         private Logger GetLoggerThreadSafe(string name, Type loggerType)
         {
+            if (name == null)
+                throw new ArgumentNullException(nameof(name), "Name of logger cannot be null");
+
             LoggerCacheKey cacheKey = new LoggerCacheKey(name, loggerType ?? typeof(Logger));
 
             lock (_syncRoot)

diff --git a/tests/NLog.UnitTests/LogFactoryTests.cs b/tests/NLog.UnitTests/LogFactoryTests.cs
@@ -384,5 +384,12 @@ public void SuspendAndResumeLogging_OutOfOrder()
             factory.ResumeLogging();
             Assert.True(factory.IsLoggingEnabled());
         }
+
+        [Fact]
+        public void LogFactory_GetLoggerWithNull_ShouldThrow()
+        {
+            LogFactory factory = new LogFactory();
+            Assert.Throws<ArgumentNullException>(() => factory.GetLogger(null));
+        }
     }
 }