small code improvement

NLog · May 25, 2019 · 7d0301b · 7d0301b
1 parent ee168fb
commit 7d0301b
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/src/NLog/Internal/ThreadSafeDictionary.cs b/src/NLog/Internal/ThreadSafeDictionary.cs
@@ -65,7 +65,7 @@ public ThreadSafeDictionary(ThreadSafeDictionary<TKey, TValue> source)
 
         public TValue this[TKey key]
         {
-            get { return GetReadOnlyDict()[key]; }
+            get => GetReadOnlyDict()[key];
             set
             {
                 lock (_lockObject)
@@ -124,16 +124,13 @@ public void CopyTo(KeyValuePair<TKey, TValue>[] array, int arrayIndex)
 
         public void CopyFrom(IDictionary<TKey, TValue> source)
         {
-            if (!ReferenceEquals(this, source))
+            if (!ReferenceEquals(this, source) && source?.Count > 0)
             {
-                if (source?.Count > 0)
+                lock (_lockObject)
                 {
-                    lock (_lockObject)
-                    {
-                        var destDict = GetWritableDict();
-                        foreach (var item in source)
-                            destDict[item.Key] = item.Value;
-                    }
+                    var destDict = GetWritableDict();
+                    foreach (var item in source)
+                        destDict[item.Key] = item.Value;
                 }
             }
         }