Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogBeginScopeParser - CaptureScopeProperties with cached scopePropertyCount #639

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

snakefoot
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 79.86% // Head: 79.97% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (4b24f04) compared to base (9442b97).
Patch coverage: 78.12% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #639      +/-   ##
==========================================
+ Coverage   79.86%   79.97%   +0.10%     
==========================================
  Files          18       18              
  Lines        1649     1648       -1     
  Branches      279      280       +1     
==========================================
+ Hits         1317     1318       +1     
+ Misses        200      197       -3     
- Partials      132      133       +1     
Impacted Files Coverage Δ
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 82.13% <ø> (-0.07%) ⬇️
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 69.83% <74.07%> (-1.52%) ⬇️
...nsions.Logging/Logging/NLogMessageParameterList.cs 91.78% <100.00%> (-0.06%) ⬇️
...ing/LayoutRenderers/ConfigSettingLayoutRenderer.cs 86.11% <0.00%> (+13.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@snakefoot snakefoot merged commit d6a874b into NLog:master Nov 14, 2022
@snakefoot snakefoot added this to the 5.2.0 milestone Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants