Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogMessageParameterList - Skip parsing Parameters-array when simple positional message template #638

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Nov 14, 2022

Skips capture of LogEventInfo.Parameters-array

Using positional-message-templates with NLog.Extensions.Logging will give high performance, since no properties-dictionary-allocation or parameters-array-allocation.

@snakefoot snakefoot changed the title NLogMessageParameterList - Reduce allocation when message template is simple positional NLogMessageParameterList - Skip property parsing when simple positional message template Nov 14, 2022
@snakefoot snakefoot merged commit 9442b97 into NLog:master Nov 14, 2022
@snakefoot snakefoot added this to the 5.2.0 milestone Nov 27, 2022
@snakefoot snakefoot changed the title NLogMessageParameterList - Skip property parsing when simple positional message template NLogMessageParameterList - Skip parsing Parameters-array when simple positional message template Nov 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant