Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nuget-dependency Microsoft.Extensions.Configuration.Abstractions for all platforms #590

Merged
merged 1 commit into from May 12, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented May 12, 2022

Newer version of Microsoft.Extensions.Logging no longer depends on Microsoft.Extensions.Configuration.Abstractions. See also #586

@snakefoot snakefoot added the dependencies Pull requests that update a dependency file label May 12, 2022
@snakefoot snakefoot added this to the 5.0 milestone May 12, 2022
@JPasterkampRotec
Copy link

This will also be working for the new 1.7.* right?

@snakefoot
Copy link
Contributor Author

Nope this for 5.0. Unless @304NotModified feels an urge to complete #576 together with this adjustment.

@JPasterkampRotec
Copy link

Will 5.0 be usable in .net framework 4.8? (I assume yes, because otherwise this fix wouldn't make sense)

@snakefoot
Copy link
Contributor Author

snakefoot commented May 12, 2022

Correct 5.0 will support .NET Framework 4.8

@snakefoot snakefoot closed this May 12, 2022
@snakefoot snakefoot reopened this May 12, 2022
@snakefoot snakefoot merged commit 7bfb75c into NLog:master May 12, 2022
@snakefoot snakefoot changed the title Added explicit Microsoft.Extensions.Configuration.Abstractions for all targets Added nuget-dependency Microsoft.Extensions.Configuration.Abstractions for all platforms May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants