Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure NLogProviderOptions from HostBuilder Configuration #581

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Mar 24, 2022

For better support of setting RemoveLoggerFactoryFilter and ReplaceLoggerFactory in appsettings.json. Resolves #578

…veLoggerFactoryFilter and ReplaceLoggerFactory
@codecov-commenter
Copy link

Codecov Report

Merging #581 (766d605) into master (9ed8683) will increase coverage by 1.00%.
The diff coverage is 90.00%.

❗ Current head 766d605 differs from pull request most recent head 0ad88a7. Consider uploading reports for the commit 0ad88a7 to get more accurate results

@@            Coverage Diff             @@
##           master     #581      +/-   ##
==========================================
+ Coverage   79.31%   80.31%   +1.00%     
==========================================
  Files          18       18              
  Lines        1566     1565       -1     
  Branches      266      265       -1     
==========================================
+ Hits         1242     1257      +15     
+ Misses        194      181      -13     
+ Partials      130      127       -3     
Impacted Files Coverage Δ
....Extensions.Logging/Logging/NLogProviderOptions.cs 94.44% <ø> (ø)
...tensions.Logging/Extensions/ConfigureExtensions.cs 66.35% <80.00%> (+8.37%) ⬆️
...ns.Logging/Internal/RegisterNLogLoggingProvider.cs 91.93% <93.93%> (+1.02%) ⬆️
...tensions.Hosting/Extensions/ConfigureExtensions.cs 84.61% <100.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ed8683...0ad88a7. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReplaceLoggerFactory option in appsettings.json not working
2 participants