Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogProviderOptions ShutdownOnDispose = true disables LogFactory.AutoShutdown #565

Merged
merged 1 commit into from Jan 9, 2022

Conversation

snakefoot
Copy link
Contributor

See also: NLog/NLog.Web#691

@snakefoot snakefoot added this to the 5.0 milestone Jan 9, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #565 (da4562f) into master (20f96b5) will decrease coverage by 0.20%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #565      +/-   ##
==========================================
- Coverage   79.67%   79.47%   -0.21%     
==========================================
  Files          18       18              
  Lines        1555     1559       +4     
  Branches      262      263       +1     
==========================================
  Hits         1239     1239              
- Misses        188      191       +3     
- Partials      128      129       +1     
Impacted Files Coverage Δ
...tensions.Hosting/Extensions/ConfigureExtensions.cs 82.85% <0.00%> (-5.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20f96b5...da4562f. Read the comment docs.

@snakefoot snakefoot merged commit 89ab799 into NLog:master Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants