Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogProviderOptions with support for RegisterServiceProvider #535

Merged
merged 2 commits into from
Oct 3, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Oct 2, 2021

@snakefoot snakefoot added this to the 5.0 milestone Oct 2, 2021
@snakefoot snakefoot force-pushed the service-repo branch 3 times, most recently from 4ab0b27 to b3e9279 Compare October 3, 2021 06:26
@codecov-commenter
Copy link

Codecov Report

Merging #535 (66e7b7e) into master (039f13a) will increase coverage by 0.09%.
The diff coverage is 87.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #535      +/-   ##
==========================================
+ Coverage   80.77%   80.87%   +0.09%     
==========================================
  Files          17       17              
  Lines        1420     1443      +23     
  Branches      232      236       +4     
==========================================
+ Hits         1147     1167      +20     
  Misses        171      171              
- Partials      102      105       +3     
Impacted Files Coverage Δ
.../LayoutRenderers/MicrosoftConsoleLayoutRenderer.cs 73.46% <ø> (ø)
...tensions.Hosting/Extensions/ConfigureExtensions.cs 83.33% <75.00%> (-1.05%) ⬇️
...tensions.Logging/Extensions/ConfigureExtensions.cs 57.98% <75.00%> (+0.59%) ⬆️
...ing/LayoutRenderers/ConfigSettingLayoutRenderer.cs 86.48% <93.33%> (+3.87%) ⬆️
....Extensions.Logging/Logging/NLogProviderOptions.cs 94.44% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 039f13a...66e7b7e. Read the comment docs.

@snakefoot snakefoot merged commit e8a8db6 into NLog:master Oct 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants