Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix NLogLoggingConfiguration to handle throwConfigExceptions with NLog 5.0 #531

Merged
merged 1 commit into from
Sep 22, 2021

Conversation

snakefoot
Copy link
Contributor

@snakefoot snakefoot commented Sep 22, 2021

Resolves #532

@codecov-commenter
Copy link

Codecov Report

Merging #531 (058bc4a) into master (c8dcd7e) will increase coverage by 0.21%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #531      +/-   ##
==========================================
+ Coverage   80.61%   80.83%   +0.21%     
==========================================
  Files          17       17              
  Lines        1424     1419       -5     
  Branches      233      232       -1     
==========================================
- Hits         1148     1147       -1     
+ Misses        173      170       -3     
+ Partials      103      102       -1     
Impacted Files Coverage Δ
...tensions.Hosting/Extensions/ConfigureExtensions.cs 84.37% <100.00%> (-1.34%) ⬇️
...ensions.Logging/Config/NLogLoggingConfiguration.cs 90.24% <100.00%> (+0.03%) ⬆️
...tensions.Logging/Extensions/ConfigureExtensions.cs 57.39% <100.00%> (+2.30%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fca5c...058bc4a. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JSON configuration always throws when throwConfigExceptions is true.
2 participants