Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLogLoggingConfiguration Reload now fully support KeepVariablesOnReload #522

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

snakefoot
Copy link
Contributor

Resolves #466

@snakefoot snakefoot added this to the 5.0 milestone Aug 26, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #522 (631e911) into master (e2bffa9) will increase coverage by 0.47%.
The diff coverage is 70.37%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #522      +/-   ##
==========================================
+ Coverage   79.95%   80.43%   +0.47%     
==========================================
  Files          17       17              
  Lines        1452     1416      -36     
  Branches      236      231       -5     
==========================================
- Hits         1161     1139      -22     
+ Misses        184      175       -9     
+ Partials      107      102       -5     
Impacted Files Coverage Δ
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 67.42% <65.32%> (+1.25%) ⬆️
src/NLog.Extensions.Logging/Logging/NLogLogger.cs 81.75% <72.22%> (+0.19%) ⬆️
...tensions.Hosting/Extensions/ConfigureExtensions.cs 85.71% <100.00%> (+0.42%) ⬆️
...ensions.Logging/Config/NLogLoggingConfiguration.cs 89.87% <100.00%> (+0.21%) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 98.27% <100.00%> (+3.03%) ⬆️
....Extensions.Logging/Logging/NLogProviderOptions.cs 100.00% <100.00%> (ø)
...tensions.Logging/Targets/MicrosoftILoggerTarget.cs 84.07% <100.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7384e7...631e911. Read the comment docs.

@snakefoot snakefoot merged commit 93b2fb8 into NLog:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix NLogLoggingConfiguration to call PrepareForReload on Reload
2 participants