Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed platform .NET 4.5.1 #486

Merged
merged 1 commit into from Aug 26, 2021

Conversation

snakefoot
Copy link
Contributor

No description provided.

@snakefoot snakefoot added breaking change build-config dependencies Pull requests that update a dependency file labels Feb 28, 2021
@snakefoot snakefoot added this to the 5.0 milestone Feb 28, 2021
@304NotModified 304NotModified changed the title Removed net451 and updated NetCoreApp3 to NetCoreApp31 (WIP) Removed .NET 4.5.1 and updated .NET Core 3 to .NET Core 3.1 (WIP) Mar 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #486 (9411dd3) into master (02852f9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #486   +/-   ##
=======================================
  Coverage   81.14%   81.14%           
=======================================
  Files          16       16           
  Lines        1379     1379           
  Branches      235      235           
=======================================
  Hits         1119     1119           
  Misses        171      171           
  Partials       89       89           
Impacted Files Coverage Δ
...Extensions.Logging/Logging/NLogBeginScopeParser.cs 64.70% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02852f9...9411dd3. Read the comment docs.

@snakefoot snakefoot changed the title Removed .NET 4.5.1 and updated .NET Core 3 to .NET Core 3.1 (WIP) Removed .NET 4.5.1 and updated .NET Core 3 to .NET Core 3.1 Aug 25, 2021
@snakefoot snakefoot force-pushed the UpdateTargetPlatformsNLog5 branch 2 times, most recently from 7933971 to b50480c Compare August 26, 2021 17:23
@snakefoot snakefoot changed the title Removed .NET 4.5.1 and updated .NET Core 3 to .NET Core 3.1 Removed platform .NET 4.5.1 Aug 26, 2021
@snakefoot snakefoot force-pushed the UpdateTargetPlatformsNLog5 branch 2 times, most recently from d5f98f5 to 00a6473 Compare August 26, 2021 17:26
@304NotModified
Copy link
Member

Funny, as I read the news post, .net 4.5 is still supported?

Maybe the title should be: remove .NET Core 1 support?

@snakefoot
Copy link
Contributor Author

Maybe the title should be: remove .NET Core 1 support?

These are still around netstandard1.3;netstandard1.5;

@snakefoot snakefoot merged commit 185d8b8 into NLog:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change build-config dependencies Pull requests that update a dependency file size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants