Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove startup overhead caused by enumerating all assemblies for callsite logic #485

Merged
merged 2 commits into from
Aug 26, 2021

Conversation

snakefoot
Copy link
Contributor

NetStandard2 is capable of hiding the LoggerFactory-assembly, and the Microsoft.Extensions.Logging.Filter only works for NetCore1.

When calling UseNLog or AddNLogWeb then NLog.Web.AspNetCore will ensure to "hide" itself.

@codecov-io
Copy link

Codecov Report

Merging #485 (e901fc7) into master (80d7d59) will decrease coverage by 0.13%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   81.15%   81.02%   -0.14%     
==========================================
  Files          14       14              
  Lines        1279     1254      -25     
  Branches      215      211       -4     
==========================================
- Hits         1038     1016      -22     
+ Misses        165      164       -1     
+ Partials       76       74       -2     
Impacted Files Coverage Δ
...tensions.Hosting/Extensions/ConfigureExtensions.cs 83.87% <100.00%> (+0.53%) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 98.27% <100.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80d7d59...e901fc7. Read the comment docs.

@codecov-commenter
Copy link

Codecov Report

Merging #485 (00ffa03) into master (87007d8) will decrease coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #485      +/-   ##
==========================================
- Coverage   79.95%   79.81%   -0.15%     
==========================================
  Files          17       17              
  Lines        1452     1427      -25     
  Branches      236      233       -3     
==========================================
- Hits         1161     1139      -22     
+ Misses        184      183       -1     
+ Partials      107      105       -2     
Impacted Files Coverage Δ
...tensions.Hosting/Extensions/ConfigureExtensions.cs 85.71% <100.00%> (+0.42%) ⬆️
...g.Extensions.Logging/Logging/NLogLoggerProvider.cs 98.27% <100.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87007d8...00ffa03. Read the comment docs.

@snakefoot snakefoot changed the title Remove startup overhead caused by enumerating all assemblies for callsite logic (WIP) Remove startup overhead caused by enumerating all assemblies for callsite logic Aug 25, 2021
@snakefoot snakefoot merged commit c999c3e into NLog:master Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants