Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update complete Python chapter #263

Merged
merged 2 commits into from
Apr 7, 2022
Merged

update complete Python chapter #263

merged 2 commits into from
Apr 7, 2022

Conversation

egpbos
Copy link
Member

@egpbos egpbos commented Apr 6, 2022

I have gone over the full Python chapter now and made some further updates (apart from those in #259, #260, #261 and #262):

  • updated documentation section to recommend sphinx only (removed pydoc)
  • removed jupyterlab "under development" caveat, it's mature now
  • added ReviewNB suggestion based on good experiences in a number of projects
  • add some minor textual changes

- minor textual changes
- updated documentation section to recommend sphinx only (removed pydoc)
- removed jupyterlab "under development" caveat, it's mature now
- added ReviewNB suggestion based on good experiences in a number of projects
@egpbos egpbos changed the title various changes in Python chapter update complete Python chapter Apr 6, 2022
@egpbos egpbos requested a review from c-martinez April 6, 2022 14:04
@egpbos
Copy link
Member Author

egpbos commented Apr 7, 2022

Note to reviewer: the link checker is failing because of dead links in master. We should make a separate PR to fix them.

Copy link
Member

@bouweandela bouweandela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! Just a few more ideas, feel free to ignore them.

best_practices/language_guides/python.md Show resolved Hide resolved
best_practices/language_guides/python.md Show resolved Hide resolved
best_practices/language_guides/python.md Show resolved Hide resolved
best_practices/language_guides/python.md Outdated Show resolved Hide resolved
@egpbos egpbos merged commit d56210d into master Apr 7, 2022
@egpbos egpbos deleted the python_various_changes branch April 7, 2022 18:58
@egpbos
Copy link
Member Author

egpbos commented Apr 7, 2022

Thanks for the review! Added your suggestions.

@c-martinez
Copy link
Member

Thanks for updates in this chapter!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants