Add search page cypress tests #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brdalsnes
requested review from
jnatten,
gunnarvelle,
N4G1,
elenaand,
OliverKnowit,
haattis,
hakmet and
ingeborgsteel
|
Hva skjer her? Fungerer lokalt |
|
Lokalt brukes graphql, men på travis må du ha en fixture. |
gunnarvelle
approved these changes
Feb 1, 2021
brdalsnes
commented
Feb 1, 2021
package.json
Outdated
| "e2e": "cypress open", | ||
| "e2e-use-fixtures": "cross-env CYPRESS_USE_FIXTURES=true cypress open", | ||
| "e2e-record-fixtures": "cross-env CYPRESS_RECORD_FIXTURES=true cypress run", | ||
| "e2e": "BABEL_ENV=test cypress open", |
There was a problem hiding this comment.
Hva skal denne være? BABEL_ENV eller NODE_ENV må være satt i cypress 6
There was a problem hiding this comment.
Tja. Kva seier cypressdokumentasjonen?
There was a problem hiding this comment.
Ser ut som det er en bug faktisk: cypress-io/cypress#6755. Kan kanskje la det stå som det er inntil videre?
There was a problem hiding this comment.
Tror kanskje vi må bruke cross-env for å sette denne for at det skal fungere likt på windows?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enkle tester for å sjekke at søkebar rendres
Oppdaterer også til cypress 6 og endrer måten GraphQL requests blir gjort:
Fixes NDLANO/Issues#1740