Use panda for icons #2200
Draft
Use panda for icons #2200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunnarvelle
reviewed
Apr 12, 2024
| import { defineTokens } from "@pandacss/dev"; | ||
|
|
||
| export default defineTokens.spacing({ | ||
| 1: { value: "2px" }, |
There was a problem hiding this comment.
Her dobler du px fra tokenet. Hadde det vore enklere å ha samme token som pixelverdi?
to ensure that global css never "wins" w.r.t specificity
Jonas-C
force-pushed
the
use-panda-for-icons
branch
2 times, most recently
from
4aab733
to
a395f44
Compare
Jonas-C
force-pushed
the
use-panda-for-icons
branch
from
a395f44
to
713670f
Compare
katrinewi
reviewed
Apr 16, 2024
| import { defineConfig } from "@pandacss/dev"; | ||
| import { preset } from "@ndla/primitives"; | ||
|
|
||
| export default defineConfig({ |
There was a problem hiding this comment.
Må vi ha en sånn her config i hver pakke? burde vi hatt en base-config som kan gjenbrukes?
There was a problem hiding this comment.
Det kan vi sikkert!
Jonas-C
force-pushed
the
panda
branch
2 times, most recently
from
936446b
to
f7d946a
Compare
Jonas-C
force-pushed
the
panda
branch
2 times, most recently
from
3fd2abe
to
6aa5900
Compare
Jonas-C
force-pushed
the
panda
branch
7 times, most recently
from
9ebb053
to
7ee6b80
Compare
Jonas-C
force-pushed
the
panda
branch
6 times, most recently
from
aaf8bfb
to
4ca5f63
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Egentlig bare et eksempel på hvordan primitives kan brukes. Realistisk sett kommer vi ikke til å reeksportere IconProps, og heller ikke Spinner. Ville bare ikke innføre noe som var kjempebreaking.