Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tweak callback_url #692

Merged
merged 4 commits into from
Mar 25, 2020
Merged

tweak callback_url #692

merged 4 commits into from
Mar 25, 2020

Conversation

damienh
Copy link

@damienh damienh commented Mar 25, 2020

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

Refactor callback_url based on issue found here omniauth/omniauth-oauth2#93

Works on staging and development

Steps to perform after deploying to production

@damienh damienh self-assigned this Mar 25, 2020
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to teachcomputing-staging-pr-692 March 25, 2020 11:27 Inactive
@damienh damienh temporarily deployed to teachcomputing-staging March 25, 2020 11:33 Inactive
@damienh damienh temporarily deployed to teachcomputing-staging March 25, 2020 11:59 Inactive
@damienh damienh had a problem deploying to teachcomputing-staging-pr-692 March 25, 2020 14:15 Failure
@damienh damienh had a problem deploying to teachcomputing-staging-pr-692 March 25, 2020 14:17 Failure
Copy link
Contributor

@glenpike glenpike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damienh damienh merged commit 20fe1d8 into master Mar 25, 2020
@damienh damienh deleted the omniauth-tweaks branch March 25, 2020 14:50
@damienh damienh restored the omniauth-tweaks branch March 26, 2020 10:45
@damienh damienh deleted the omniauth-tweaks branch March 26, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants