Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try new approach for callback url #691

Closed
wants to merge 4 commits into from
Closed

Try new approach for callback url #691

wants to merge 4 commits into from

Conversation

damienh
Copy link

@damienh damienh commented Mar 25, 2020

Status

Review progress:

  • Browser tested
  • Front-end review completed
  • Tech review completed

What's changed?

Try new approach for callback_url to match issues found here omniauth/omniauth-oauth2#93

Bump omniauth-oauth2

Steps to perform after deploying to production

Test on staging first.

@damienh damienh self-assigned this Mar 25, 2020
@raspberrypiherokubot raspberrypiherokubot temporarily deployed to teachcomputing-staging-pr-691 March 25, 2020 10:50 Inactive
@damienh damienh temporarily deployed to teachcomputing-staging-pr-691 March 25, 2020 11:04 Inactive
@damienh damienh closed this Mar 25, 2020
@damienh damienh deleted the try-new-approach-for-callback-url branch March 25, 2020 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@damienh @raspberrypiherokubot