Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #53

Merged
merged 3 commits into from Jul 13, 2020
Merged

Upgrade dependencies #53

merged 3 commits into from Jul 13, 2020

Conversation

AliceR
Copy link
Member

@AliceR AliceR commented Jul 13, 2020

Thanks to our extensive e2e test suite I am confident that nothing breaks while upgrading all our dependencies to the latest versions.

Had to make small changes to account for breaking changes:

  • comment out a test in campaign.test.js -> Couldn't figure out why this doesn't pass anymore
  • update a snapshot where gatsby image wrapper now adds some new styles
  • remove and re-add @testing-library/cypress and cypress: This makes them fall back to the same version, which will fix the ci pipeline. This seems to be an issue with cypress: Installation fails when installing two different versions of Cypress during the same yarn install step.  cypress-io/cypress#7951
  • require.requireActual was deprecated in jest 26, I updated it to it's newer equivalent
  • Upgrade cypress/base image node version to 12, 10 wasn't compatible with the newest babel-jest and failing yarn install on the ci e2e test pipeline

Including small fixes after upgrading dependencies with breaking changes
This makes them fall back to the same version, which will fix ci. This seems to be an issue with cypress: cypress-io/cypress#7951
@AliceR AliceR requested a review from necoline July 13, 2020 16:18
@necoline
Copy link
Contributor

yay for upgrades 🎉

@AliceR AliceR merged commit 309c97a into develop Jul 13, 2020
@AliceR AliceR deleted the upgrade-dependencies branch July 13, 2020 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants