Skip to content
This repository has been archived by the owner on Mar 13, 2023. It is now read-only.

Set a minimum version of attrs that supports our use of python 3.11 #745

Merged
merged 2 commits into from Jan 5, 2023

Conversation

silasary
Copy link
Collaborator

@silasary silasary commented Jan 4, 2023

What type of pull request is this?

  • Non-breaking code change
  • Breaking code change
  • Documentation change/addition
  • Tests change
  • CI change
  • Other: [Replace with a description]

Description

Fixes the bug Wolf found the other day

Changes

Sets a minimum version of attrs to one that contains python-attrs/attrs#969

Checklist

  • I've formatted my code with Black
  • I've added docstrings to everything I've touched
  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x
  • I've tested my changes
  • I've added tests for my code - if applicable
  • I've updated the documentation - if applicable

@Wolfhound905
Copy link
Collaborator

Please update the poetry files too.

@silasary
Copy link
Collaborator Author

silasary commented Jan 4, 2023

I had to figure out how to use poetry, but done 😛

Copy link
Collaborator

@Wolfhound905 Wolfhound905 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LordOfPolls LordOfPolls merged commit 5604b19 into dev Jan 5, 2023
@LordOfPolls LordOfPolls deleted the attrs-11 branch January 5, 2023 15:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants