Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for closing and re-opening non-fullscreen modals on iOS fast not working correctly #4554

Merged
merged 7 commits into from
Jan 20, 2023

Conversation

Digifais
Copy link
Contributor

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

This is a new bug fix for #3546 since #4040 didn't completely fix this. When showing a non-fullscreen modal, swipe to close, re-open it fast, repeat if needed for x amount of times, the following error is thrown in the application output:

[Presentation] Attempt to present <MvvmCross_Platforms_Ios_Views_MvxNavigationController: 0x7fdae1b74a00> on <MvvmCross_Platforms_Ios_Views_MvxNavigationController: 0x7fdae69c8c00> (from <MvvmCross_Platforms_Ios_Views_MvxNavigationController: 0x7fdae69c8c00>) whose view is not in the window hierarchy.

⤵️ What is the current behavior?

Error from #3546 still sometimes occurs when closing and re-opening non-fullscreen modals on iOS fast.

🆕 What is the new behavior (if this is a feature change)?

Closing and re-opening non-fullscreen modals on iOS fast should work correctly now.

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

Show a non-fullscreen modal, swipe to close, re-open it fast, repeat if needed for x amount of times.

📝 Links to relevant issues/docs

#3546
#4040

🤔 Checklist before submitting

…ationControllerDelegate instead of WillDismiss
@Cheesebaron
Copy link
Member

Thank you for the PR 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants