Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from IntPtr to NativeHandle #4545

Merged
merged 2 commits into from
Jan 12, 2023
Merged

Conversation

Cheesebaron
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

in net6.0-ios we should not use IntPtr ctors, instead we should use NativeHandle

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

Yes, signature changes of many ctors

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@Cheesebaron Cheesebaron added p/ios iOS platform t/breaking Breaking Change type labels Jan 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Cheesebaron Cheesebaron enabled auto-merge (squash) January 12, 2023 12:09
@Cheesebaron Cheesebaron merged commit 78fbcee into develop Jan 12, 2023
@Cheesebaron Cheesebaron deleted the bugfix/intptr-nativehandle branch January 12, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/ios iOS platform t/breaking Breaking Change type
Development

Successfully merging this pull request may close these issues.

None yet

1 participant