Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nullable warnings with a lot of Mvx.IoCProvider usages #4543

Merged
merged 1 commit into from
Jan 10, 2023

Conversation

Cheesebaron
Copy link
Member

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

Potential crashes when IoCProvider is null (which is rare, but can happen on Android re-hydration)

🆕 What is the new behavior (if this is a feature change)?

💥 Does this PR introduce a breaking change?

🐛 Recommendations for testing

📝 Links to relevant issues/docs

🤔 Checklist before submitting

@Cheesebaron Cheesebaron added the t/bug Bug type label Jan 10, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@Cheesebaron Cheesebaron merged commit 50a67c6 into develop Jan 10, 2023
@Cheesebaron Cheesebaron deleted the bugfix/iocprovider-nullability branch January 10, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t/bug Bug type
Development

Successfully merging this pull request may close these issues.

None yet

1 participant