[coverage-revision] Use CI coverage revision when possible #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
This might be easier in fuzzfetch, but what about checking for stale revisions? (like we just saw)
ie. Fetch the CI_LATEST from mozcov, fetch the metadata with fuzzfetch --build $CI_LATEST, and if it looks like it's older than a week, then fallback as if we didn't get a good revision. Otherwise we may end up doing coverage runs on revisions we've already collected coverage for, which is a waste of time, and masks the problem.
|
|
||
| # Validate that we got a proper revision | ||
| CI_LATEST=$(retry-curl --silent https://api.coverage.moz.tools/v2/history | jq -r '.[0].changeset') |
There was a problem hiding this comment.
--silent is already included in retry-curl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.