Replace 'kebab-case' to 'hyphen-case' #2646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since 'kebab-case' may be perceived as derogatory by some members of Arabic or Asian cultures, it's better to use a culture-agnostic term like 'hyphen-case', which in addition is more self-explanatory than the potentially offensive term 'kebab-case', which makes no sense without knowing the origin of the term.
Markel
approved these changes
Apr 10, 2021
There was a problem hiding this comment.
Glad to see that you managed to submit the PR (and yes, VSCode is very handy indeed).
Seems Unix vs. Windows line endings in changelog have tricked you a little bit (do not worry about it, it doesn't matter, I just comment it to have it searchable in the future).
The PR is great, glad to have contributions like this! 🎉
Comment on lines
-1613
to
+1614
| - Add check to verify that enableClasses has been initialized. [`39fc8fa`](https://github.com/Modernizr/Modernizr/commit/39fc8faa3eefab70b5c096f9c29629cdb0bbc402) | ||
| - Add check to verify that enableClasses has been initialized. | ||
| [`39fc8fa`](https://github.com/Modernizr/Modernizr/commit/39fc8faa3eefab70b5c096f9c29629cdb0bbc402) |
Comment on lines
-1975
to
+1977
| - https://github.com/Modernizr/Modernizr/issues/423 [`22c6779`](https://github.com/Modernizr/Modernizr/commit/22c6779d3b450c2681ba24501be5b2b2ca42e4d2) | ||
| - https://github.com/Modernizr/Modernizr/issues/423 | ||
| [`22c6779`](https://github.com/Modernizr/Modernizr/commit/22c6779d3b450c2681ba24501be5b2b2ca42e4d2) |
Comment on lines
-1995
to
+1998
| - If the test added via addTest is NOT a function or Boolean Modernizr dies. [`1c2feb5`](https://github.com/Modernizr/Modernizr/commit/1c2feb5722fb0beee574bd0ea7054c883341c45a) | ||
| - If the test added via addTest is NOT a function or Boolean Modernizr dies. | ||
| [`1c2feb5`](https://github.com/Modernizr/Modernizr/commit/1c2feb5722fb0beee574bd0ea7054c883341c45a) |
Comment on lines
-2014
to
+2018
| - `/^[23]g$/` is the new `/^(?:2g|3g)$/`. [`3e27e8a`](https://github.com/Modernizr/Modernizr/commit/3e27e8ad8a1e8a91d0487a46d5bd9f55c091d214) | ||
| - `/^[23]g$/` is the new `/^(?:2g|3g)$/`. | ||
| [`3e27e8a`](https://github.com/Modernizr/Modernizr/commit/3e27e8ad8a1e8a91d0487a46d5bd9f55c091d214) |
Comment on lines
-2017
to
+2022
| - Do NOT cast `test` to a Boolean. Truthy/falsy values are okay and casting will break some of the built in tests that use a Boolean *object* with added properties (the audio/video tests do this). [`f8ccf69`](https://github.com/Modernizr/Modernizr/commit/f8ccf69369e9fe560e300a2096c6bb5415187913) | ||
| - Do NOT cast `test` to a Boolean. Truthy/falsy values are okay and casting will break some of the built in tests that use a Boolean *object* with added properties (the audio/video tests do this). | ||
| [`f8ccf69`](https://github.com/Modernizr/Modernizr/commit/f8ccf69369e9fe560e300a2096c6bb5415187913) |
|
Markel, thanks a lot for your help :) About line endings, I thought I had my local git configured as to not mess with line endings, using whatever the repository had, and if none, forcing Unix ones. I have checked the local copy I cloned and in fact Sorry for the inconvenience. |
|
Thx for the PR @DervishD |
rejas
pushed a commit
that referenced
this pull request
Apr 10, 2021
Since 'kebab-case' may be perceived as derogatory by some members of Arabic or Asian cultures, it's better to use a culture-agnostic term like 'hyphen-case', which in addition is more self-explanatory than the potentially offensive term 'kebab-case', which makes no sense without knowing the origin of the term.
|
My pleasure, @rejas :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 'kebab-case' may be perceived as derogatory by some members of
Arabic or Asian cultures, it's better to use a culture-agnostic term
like 'hyphen-case', which in addition is more self-explanatory than the
potentially offensive term 'kebab-case', which makes no sense without
knowing the origin of the term.