Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ZeroizeOnDrop #32

Merged
merged 4 commits into from Jan 9, 2022
Merged

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Jan 5, 2022

This is waiting for RustCrypto/utils#700 and a new release. Deprecates Zeroize(drop) in favor of ZeroizeOnDrop.

non-msrv-tests/tests/ui/zeroize/zeroize.rs Show resolved Hide resolved
src/input.rs Outdated Show resolved Hide resolved
@daxpedda daxpedda requested a review from ModProg January 5, 2022 11:12
@daxpedda daxpedda marked this pull request as ready for review January 9, 2022 03:27
@daxpedda
Copy link
Collaborator Author

daxpedda commented Jan 9, 2022

This is ready to be merged now that the new version of Zeroize is out. I'm still providing backwards compatibility, especially because the new version is not a stable release.

I would say we can talk about actually enabling this feature by default at some point in the future.

@daxpedda daxpedda force-pushed the zeroize-on-drop branch 2 times, most recently from 5919427 to 3bf6c45 Compare January 9, 2022 03:42
@ModProg ModProg merged commit cacc350 into ModProg:main Jan 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants