-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR] AuthZ and AuthN for MobSF + Bug Fixes #2366
Conversation
👋 @ajinabraham |
Many security issues can be avoided using the django-allauth module. |
For basic username/password authentication and account management, Django has decent inbuilt authentication APIs. Will consider django-allauth or others if we plan to support other authentication strategies. |
@ajinabraham Great stuff, let me test 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good! also tried some Pen testing on it, seems solid
Let me know what you think / if you need help
@matandobr I guess, I have addressed the review comments. |
Describe the Pull Request
Checklist for PR
tox -e lint,test
StaticAnalyzer/tests.py
)Additional Comments (if any)