-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor, move from react-scripts to vite #333
Open
mihirsamdarshi
wants to merge
14
commits into
dev
Choose a base branch
from
refactor/vite
base: dev
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihirsamdarshi
force-pushed
the
refactor/vite
branch
2 times, most recently
from
May 3, 2024 21:53
fe590f3
to
359a341
Compare
mihirsamdarshi
force-pushed
the
refactor/vite
branch
3 times, most recently
from
May 4, 2024 00:45
e7ad0d7
to
f45d520
Compare
mihirsamdarshi
changed the title
refactor/vite
Refactor, move from react-scripts to vit4e
May 4, 2024
mihirsamdarshi
changed the title
Refactor, move from react-scripts to vit4e
Refactor, move from react-scripts to vite
May 4, 2024
mihirsamdarshi
force-pushed
the
refactor/vite
branch
2 times, most recently
from
May 9, 2024 08:12
906ede8
to
f1c9f89
Compare
- vis-network-react is distributed as CommonJS instead of ESM
mihirsamdarshi
force-pushed
the
refactor/vite
branch
3 times, most recently
from
May 10, 2024 06:04
4ea4101
to
8afa38f
Compare
mihirsamdarshi
force-pushed
the
refactor/vite
branch
from
May 10, 2024 06:11
8afa38f
to
a59fca5
Compare
mihirsamdarshi
force-pushed
the
refactor/vite
branch
from
May 10, 2024 10:55
b653dbb
to
06bf0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a number of changes.
React no longer maintains
create-react-app
, and a number of the packages that the frontend were using have long been deprecatedHere are all the changes introduced by this PR:
react-scripts
->vite
refactorreact-scripts
withvite
react-scripts
has long been deprecated in favor of full-stack frameworks like Gatsby, NextJS, or Remixreact-scripts
package.json scripts withvite
commandsprocess.env
accessor toimport.meta
REACT_APP_
style environment variables supported bycreate-react-app
toVITE_
style environment variables supported byvite
vite.config.js
, usingreact-swc
React compiler plugin.react-router
v5 to v6 upgradeRedirect
component withNavigate
componentwithTracking
HOC with a wrapper layout router with the same functionalityPrivateRoute
with a newAuthWrapper
necessitated by direct-rendering changes in v6lazy
docs to see how code splitting workslazy
docs on React Router for howlazy
loading routes works<Suspense>
element (located inApp.js
, which currently renders a blank<div>
instead of any loading viewsReplace
jest
withvitest
react-scripts
necessitates the introduction of a test frameworkvitest
is a drop-in replacement forjest
that works for thevite
frameworkMisc changes
Regressions
react-router
's new transparent<Outlet>
component for rendering routes. For example, the main MoTrPAC logo is slightly larger than normal, and sometimes clips the headerREACT_APP_
-styled env vars are replaced byVITE_
style env vars