Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve mocks and render/tests/test-attributes #1859

Merged
merged 2 commits into from
May 29, 2017
Merged

Conversation

pygy
Copy link
Member

@pygy pygy commented May 28, 2017

This is a preliminary PR before I move on with the actual fixes for #1804 and #1595 redux.

The tests commented out are failing, but shouldn't.

@pygy pygy requested review from lhorie and dead-claudia May 28, 2017 17:58
Copy link
Member

@dead-claudia dead-claudia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I do wonder why we're using elem.attributes instead of the more idiomatic, shorter elem.getAttribute(). It'd simplify that part of the mock by a lot.

@pygy pygy removed the request for review from lhorie May 29, 2017 08:03
@pygy pygy merged commit a9838be into MithrilJS:next May 29, 2017
@pygy
Copy link
Member Author

pygy commented May 29, 2017

Thanks for the review @isiahmeadows

I agree, using getAttribute() would enable simpler mocks, but what we have works... I'm not in a hurry to replace them. I changed .nodeValue to .value because attributes soon won't be implementing the Node interface anymore. FIrefox already gives deprecation warnings.

@dead-claudia
Copy link
Member

dead-claudia commented May 31, 2017

I agree with that, and it's probably for the best. I might some day address that, but for now, meh.

¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants