Override namespace with xmlns attribute #1825
Conversation
Fixes issue #1819 foreignObject inside SVG
|
Nope, seems real weird though. |
|
I suspect it's probably a GH webhook issue, or else it'd at least show something here (e.g. an infinitely pending Travis build). |
|
yeah, not seeing anything on travis. Can you maybe try to push an empty commit to see if it kicks in again? @SamuelTilly |
|
looks like it got rejected by travis "abuse detected: known offender (request looked fishy)" https://travis-ci.org/lhorie/mithril.js/requests, looks like it was originally triggered from this " abuse detected: user page on GitHub gives 404 (request looked fishy) " weird. |
|
@lhorie So I guess you get to contact Travis, then... 😦 |
|
Yeah, got flagged for having an old link on my personal page, never bothered to remove it. contacted the support now. |
|
@SamuelTilly Could you tell us here once it's resolved? |
|
@isiahmeadows will do :) |
render/render.js
Outdated
| } | ||
|
|
||
| return ns = vnode.attrs && vnode.attrs.xmlns || ns[vnode.tag] |
There was a problem hiding this comment.
return ns = vnode.attrs smells fishy...
Also, you could put the ns object in the parent scope to avoid re-creating it every time getNameSpace() is called.
There was a problem hiding this comment.
valid points, i updated the pr :)
|
Some feedback sent... also, feel free to squash locally and force-push (alternatively, we can also squash the commits from the GH UI when merging). |
|
LGTM (hence the merge) |
Fixes issue #1819 foreignObject inside SVG