Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in support for workflow_dispatch events #143

Merged
merged 18 commits into from
Nov 22, 2023

Conversation

alexjyong
Copy link
Contributor

This PR will allow this action to be used on workflow_dispatch events. The user will be required to pass a PR number via issue-number in the inputs, but this will allow folks to get coverage reports on demand in a github action instead of having to tie it to a pull-request/push event.

I needed this for a work project, so I figured I'd share this with everyone else!

@MishaKav
Copy link
Owner

great idea! I will take a look in the next few days and make a release for your new feature.

@alexjyong
Copy link
Contributor Author

@MishaKav Thank you! Let me know if you need anything from me.

@alexjyong
Copy link
Contributor Author

updated some merge conflicts that cropped up.

@alexjyong
Copy link
Contributor Author

Ah I see this got folded in another PR. anything else needed from here or can we close this?

@MishaKav MishaKav changed the base branch from main to add-support-for-branch-coverage November 22, 2023 14:05
@MishaKav MishaKav changed the base branch from add-support-for-branch-coverage to support-pr-in-workflow-dispatch November 22, 2023 14:07
@MishaKav MishaKav merged commit c6f8b9a into MishaKav:support-pr-in-workflow-dispatch Nov 22, 2023
1 check failed
@MishaKav
Copy link
Owner

@alexjyong I tried to bump a new version and release your feature, but it can't build successfully, because you have Parsing error: Unexpected token else
Can you please provide a fix for that? This is the branch with your changes https://github.com/MishaKav/pytest-coverage-comment/compare/support-pr-in-workflow-dispatch?expand=1
image

@alexjyong
Copy link
Contributor Author

Sure thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants