Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Thumbor 7.5.0 and Python 3.11 #132

Merged
merged 1 commit into from
Jun 13, 2023

Conversation

ayr-ton
Copy link
Contributor

@ayr-ton ayr-ton commented Jun 2, 2023

Upgrade to latest thumbor (at the moment).

Also, suggesting Python 3.11 as base image as it's supported by 7.5.0 version and it has a faster garbage collector.

@gingerlime
Copy link
Contributor

Thanks @ayr-ton this looks great, but I'm getting a bizarre build problem that I'm not sure how to solve (unrelated to those changes). Perhaps @mpdude or @danquack have an idea?

*******************************************************
Docker images:
REPOSITORY                                         TAG               IMAGE ID       CREATED              SIZE
ghcr.io/minimalcompact/thumbor                     7.5.0-simd-avx2   9122f7dd0eec   15 seconds ago       1.95GB
ghcr.io/minimalcompact/thumbor                     7.5.0-simd-sse4   a661582638d3   About a minute ago   1.95GB
ghcr.io/minimalcompact/thumbor                     7.5.0             02fa8308867e   2 minutes ago        1.94GB
ghcr.io/minimalcompact/thumbor                     test              02fa8308867e   2 minutes ago        1.94GB
ghcr.io/minimalcompact/thumbor-nginx-proxy-cache   7.5.0             86bb48205554   4 minutes ago        159MB
ghcr.io/minimalcompact/thumbor-nginx-proxy-cache   test              86bb48205554   4 minutes ago        159MB
ubuntu                                             18.04             97ba4bbc97fc   3 weeks ago          63.2MB
node                                               16                9b7ab79e69b7   4 weeks ago          909MB
node                                               18                acb969b80f38   4 weeks ago          996MB
buildpack-deps                                     buster            3f4a705ee510   4 weeks ago          802MB
buildpack-deps                                     bullseye          ee020692a4d4   4 weeks ago          833MB
debian                                             10                dd20fc9536df   4 weeks ago          114MB
debian                                             11                34b4fa67dc04   4 weeks ago          124MB
ubuntu                                             22.04             3b418d7b466a   5 weeks ago          77.8MB
moby/buildkit                                      buildx-stable-1   152ba3e57b49   6 weeks ago          168MB
moby/buildkit                                      latest            152ba3e57b49   6 weeks ago          168MB
node                                               18-alpine         6f44d13dd258   7 weeks ago          175MB
ubuntu                                             20.04             88bd68917189   7 weeks ago          72.8MB
node                                               14                1d12470fa662   7 weeks ago          912MB
node                                               14-alpine         0dac3dc27b1a   2 months ago         119MB
node                                               16-alpine         8cf71856f96e   2 months ago         117MB
alpine                                             3.14              9e179bacf43c   2 months ago         5.61MB
alpine                                             3.15              58c0644b45ff   2 months ago         5.59MB
alpine                                             3.16              8471affe5de5   2 months ago         5.54MB
alpine                                             3.17              9ed4aefc74f6   2 months ago         7.04MB
tonistiigi/binfmt                                  latest            354472a37893   10 months ago        60.2MB
--> BUILDING minimalcompact/remotecv
#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 433B done
#1 DONE 0.0s

#2 [internal] load .dockerignore
#2 transferring context: 2B done
#2 DONE 0.0s

#3 [internal] load metadata for ghcr.io/minimalcompact/thumbor:7.5.0
#3 ERROR: ghcr.io/minimalcompact/thumbor:7.5.0: not found
------
 > [internal] load metadata for ghcr.io/minimalcompact/thumbor:7.5.0:
------
Dockerfile:2
--------------------
   1 |     ARG THUMBOR_TAG=latest
   2 | >>> FROM ghcr.io/minimalcompact/thumbor:$THUMBOR_TAG
   3 |     
   4 |     LABEL maintainer="MinimalCompact"
--------------------
ERROR: failed to solve: ghcr.io/minimalcompact/thumbor:7.5.0: ghcr.io/minimalcompact/thumbor:7.5.0: not found
Error: Process completed with exit code 1.

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Jun 3, 2023

I'm investigating the issue and I will let you know if I found the solution as well.

@gingerlime
Copy link
Contributor

@ayr-ton see #134. I rolled-back buildx / multi-arch support for now, since it seems difficult for me to support. would you like to rebase your changes and update the PR? I would imagine the build/test process should now work fine and we can continue to release future versions (albeit without multi-arch support). I'm happy to switch back to buildx / multi-arch if we can get the build/push process to work, but at the moment it seems brittle.

@ayr-ton
Copy link
Contributor Author

ayr-ton commented Jun 13, 2023

@gingerlime rebased o/

@gingerlime gingerlime merged commit 2eb2136 into MinimalCompact:master Jun 13, 2023
1 check passed
@gingerlime
Copy link
Contributor

Thank you @ayr-ton. Merged and it should build and push the new images to ghcr soon.

lachesis pushed a commit to zincio/docker-thumbor that referenced this pull request Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants