Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick fix for "undefined local variable or method `query_string #597

Merged
merged 2 commits into from Dec 7, 2023
Merged

Quick fix for "undefined local variable or method `query_string #597

merged 2 commits into from Dec 7, 2023

Conversation

braindeaf
Copy link
Contributor

Today's update missed one 'query_string' variable.

  local variable or method `query_string'
Copy link
Contributor

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This is on the basic happy path. Are there no tests on this action?

@braindeaf
Copy link
Contributor Author

LGTM

This is on the basic happy path. Are there no tests on this action?

I wasn't wholly sure where to add the spec, took inspiration from the stackprof example

@nateberkopec
Copy link
Collaborator

Whoops! And thank you for the test.

@nateberkopec nateberkopec merged commit 3c03459 into MiniProfiler:master Dec 7, 2023
4 checks passed
@nateberkopec
Copy link
Collaborator

Released as 3.2.1

@braindeaf braindeaf deleted the rl/query_string_fix branch December 7, 2023 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants