Refactor html and page serveing logic into modules #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… suffix. Move those to their own actions module
…were missing client_settings
nateberkopec
reviewed
Nov 2, 2023
nateberkopec
approved these changes
Nov 2, 2023
website/sample.rb
Outdated
| @@ -94,6 +94,7 @@ def create_fake_snapshot(method, path, duration, started_at) | |||
| end | |||
| end | |||
|
|
|||
| Rack::MiniProfiler.config.enable_advanced_debugging_tools = true | |||
There was a problem hiding this comment.
Sorta. I didn't intend to commit this, but I needed to add it to be able to test everything. I can extract it to another PR though.
lib/mini_profiler/actions.rb
Outdated
| class MiniProfiler | ||
| module Actions | ||
| def serve_snapshot(env) | ||
| self.current = nil |
There was a problem hiding this comment.
Maybe should be top level as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt to try to cleanup MiniProfiler. I started trying to group similar logic together to pull out to its own module, and the ones that stood out had to do with serving an HTTP response directly (ie actions) and generating HTML for said response.
That lead me to introducing
ActionsandHTMLmodules. This is just grouping methods into logical modules and including them, so it really change much functionally. It does let you see similar methods a lot closer together.For
Actions, most of the methods were already namedserve_, so I moved those to Actions. Anything else that was serving up a request directly was moved there and named as well.I changed
serve_htmla little because despite the name, it does serve up other things. I hoisted those conditionals for snapshot, results, and flamegraphs out of the method to the one place where serve_html was called.