Refactor "can gzip requests" spec to fix race condition #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This spec had a race condition caused by the date and time in the "local file header" of the zip file. See https://en.wikipedia.org/wiki/ZIP_(file_format)#File_headers This could result in the zip file that we compute during the test to be different from the zip file that the transporter sends in the HTTP request. This in turn caused stub_request(:post, url) to not match the request made in the transporter. By asserting that decompressing the transporter's request body results in the original JSON, we avoid this race condition and clarify the intention of the test assertion. Fixes MiniProfiler#569
|
Thank you so much for your detailed dive into this @willkoehler! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #569