Profile parameter config #553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It does make the code a tad harder to read but I definitely think this should be configurable, so LGTM. Rebase to show you're green on CI and let's 🚢 |
Allow profile query parameter to be configured using `Rack::MiniProfiler.profile_parameter`. Sometimes, an application may want to use a configurable profiler parameter to obscure or customize how profiles are collected. This is especially true for production environments.
nateberkopec
force-pushed
the
profile_parameter_config
branch
from
f445871
to
bcf29af
Compare
nateberkopec
force-pushed
the
profile_parameter_config
branch
from
bcf29af
to
7f6e09b
Compare
nateberkopec
force-pushed
the
profile_parameter_config
branch
from
a3cba9b
to
835243d
Compare
ohbarye
added a commit
to ohbarye/rack-mini-profiler
that referenced
this pull request
Jun 11, 2023
Profile parameter got config-able with MiniProfiler#553, but framegraph ability has been still depending on `pp`. It should be use `@config.profile_parameter`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow profile query parameter to be configured using
Rack::MiniProfiler.profile_parameter. Sometimes, an application may want to use a configurable profiler parameter to obscure or customize how profiles are collected. This is especially true for production environments.I also formatted the config option table to make it easier to read without markdown parsing, but I can revert that if need be. It really only helps if you have a 120+ character screen width.