Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: Introduce pp=async-flamegraph for asynchronous flamegraphs #494

Merged
merged 6 commits into from Apr 28, 2021

Commits on Apr 27, 2021

  1. FEATURE: Introduce pp=async-flamegraph for asynchronous flamegraphs

    Using `?pp=async-flamegraph` causes the flamegraph data to be stored in the page_struct, and made available via a link in the mini_profiler UI. Flamegraph data will also be recorded and stored for all AJAX requests with `?pp=async-flamegraph` in the `Referer` header. This is useful in a few situations:
    
    - You want to view flamegraphs for AJAX requests made by a Javascript application. By supplying `pp=async-flamegraph`, flamegraph links for every AJAX request will be made available in the mini-profiler UI.
    
    - You want to see the HTML result of a request, and view the flamegraph later. The existing `?pp=flamegraph` option hides the true output.
    
    - You are performing the request via a tool like `curl`, and would like to view the flamegraph later in the browser (you can extract the X-MiniProfiler-Ids header from the response, then view flamegraph in the browser)
    davidtaylorhq committed Apr 27, 2021
    Copy the full SHA
    be2f329 View commit details
    Browse the repository at this point in the history
  2. Fix rubocop offense

    davidtaylorhq committed Apr 27, 2021
    Copy the full SHA
    1b8d112 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Avoid serializing the entire flamegraph unnecessarily

    All we need for the `results` route is a boolean. The `/flamegraph` route takes care of the actual flamegraph data
    davidtaylorhq committed Apr 28, 2021
    Copy the full SHA
    cd59a7b View commit details
    Browse the repository at this point in the history
  2. Copy the full SHA
    25dcfa6 View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    f15be94 View commit details
    Browse the repository at this point in the history
  4. Fix rubocop

    OsamaSayegh committed Apr 28, 2021
    Copy the full SHA
    41398c8 View commit details
    Browse the repository at this point in the history