Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix profiler pop-up extending beyond the window, impossible to scroll #492

Merged
merged 1 commit into from Apr 13, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/html/includes.js
Expand Up @@ -401,7 +401,7 @@ var _MiniProfiler = (function() {
var px = button.offsetTop - 1,
// position next to the button we clicked
windowHeight = window.innerHeight,
maxHeight = windowHeight - 40; // make sure the popup doesn't extend below the fold
maxHeight = windowHeight - px - 40; // make sure the popup doesn't extend below the fold

popup.style[options.renderVerticalPosition] = "".concat(px, "px");
popup.style.maxHeight = "".concat(maxHeight, "px");
Expand Down