New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Redis 4.2 warnings. #450
Conversation
@casperisfine what should our approach be here. Our dependency on redis is "weak" in that there is no explicit dependency. Should we monkey patch it in and keep this code? |
We can just implement |
as long as it is backwards compatible with reasonable redis gem releases for whatever definition of reasonable that we can come up with |
We're only using a single key so it should be backwards compatible all the way |
Yeah, based on your constraints I'd do this: 44dee3d If the unless Redis.method_defined?(:exists?)
module RedisExistsRefinement
refine Redis do
def exists?(key)
exists(key)
end
end
end
using RedisExistsRefinement
end |
Would it be possible to have a release that includes this PR? This is currently preventing our upgrade to the Redis 4.2 |
@renchap sure, just pushed a release. |
Amazing thanks! |
Apps on Redis 4.2 and up will see a warning due to redis/redis-rb@3257527