Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dockerfile with explicit ruby, bundler versions #123

Merged
merged 2 commits into from Dec 29, 2023
Merged

Conversation

charles-uno
Copy link
Contributor

The newest version of Bundler requires Ruby 3. This breaks our Docker workflow for local development.

I first tried bumping up to Ruby 3, but ran into the same problem described here. The fix seems to be updating to a newer Jekyll. However, when I try that, I run into version conflicts in Liquid (more info here).

Easiest way forward is to keep using Ruby 2 for now. Updated the Dockerfile to be explicit about Ruby and Bundler versions rather than using the most recent.

My guess is that GitHub Pages is doing the same in prod. But it would be nice to confirm. We'll see if I can figure out how to expose versions for the underlying Ruby, Bundler, and/or Jekyll.

@charles-uno
Copy link
Contributor Author

There is a plugin that allows you to see the version of your repo: https://github.com/rob-murray/jekyll-version-plugin/blob/master/lib/jekyll_version_plugin.rb

In principle we could hack that to run gem list instead

@charles-uno
Copy link
Contributor Author

Sorry for the auto-indent noise. This is what I added:

Screenshot 2023-12-28 at 3 51 53 PM

@agude
Copy link
Member

agude commented Dec 29, 2023

Can we add a Prod check around the debug?

{% if jekyll.environment != "production" %}
  <div class="debug">
      <p>Jekyll version: {{ site.github.versions.jekyll }}</p>
      <p>Liquid version: {{ site.github.versions.liquid }}</p>
      <p>Jekyll environment: {{ jekyll.environment }}</p>
    </div>
{% endif %}

@charles-uno
Copy link
Contributor Author

Can we add a Prod check around the debug?

I want it in prod though. I want to see what versions GitHub pages is running. Could throw display:none on there if the temporary ugliness bothers you?

@agude
Copy link
Member

agude commented Dec 29, 2023 via email

@agude agude merged commit 8cc5398 into main Dec 29, 2023
@agude agude deleted the docker-ruby-3 branch December 29, 2023 02:52
agude added a commit to agude/agude.github.io that referenced this pull request Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants