Merge Decoder methods to avoid wrong remark about necessarily of `enc…

…oding` feature for them in the doc

This also allow to show doc for both variants of the methods

src/encoding.rs

@@ -54,55 +54,47 @@ impl Decoder {
     }
 }
 
-#[cfg(not(feature = "encoding"))]
-impl Decoder {
-    /// Decodes a UTF8 slice regardless of XML declaration and ignoring BOM if
-    /// it is present in the `bytes`.
-    ///
-    /// Returns an error in case of malformed sequences in the `bytes`.
-    ///
-    /// If you instead want to use XML declared encoding, use the `encoding` feature
-    #[inline]
-    pub fn decode<'b>(&self, bytes: &'b [u8]) -> Result<Cow<'b, str>> {
-        Ok(Cow::Borrowed(std::str::from_utf8(bytes)?))
-    }
-
-    /// Decodes a slice regardless of XML declaration with BOM removal if
-    /// it is present in the `bytes`.
-    ///
-    /// Returns an error in case of malformed sequences in the `bytes`.
-    ///
-    /// If you instead want to use XML declared encoding, use the `encoding` feature
-    pub fn decode_with_bom_removal<'b>(&self, bytes: &'b [u8]) -> Result<Cow<'b, str>> {
-        let bytes = if bytes.starts_with(UTF8_BOM) {
-            &bytes[3..]
-        } else {
-            bytes
-        };
-        self.decode(bytes)
-    }
-}
-
-#[cfg(feature = "encoding")]
 impl Decoder {
     /// Returns the `Reader`s encoding.
     ///
     /// This encoding will be used by [`decode`].
     ///
     /// [`decode`]: Self::decode
+    #[cfg(feature = "encoding")]
     pub fn encoding(&self) -> &'static Encoding {
         self.encoding
     }
 
+    /// ## Without `encoding` feature
+    ///
+    /// Decodes an UTF-8 slice regardless of XML declaration and ignoring BOM
+    /// if it is present in the `bytes`.
+    ///
+    /// ## With `encoding` feature
+    ///
     /// Decodes specified bytes using encoding, declared in the XML, if it was
     /// declared there, or UTF-8 otherwise, and ignoring BOM if it is present
     /// in the `bytes`.
     ///
+    /// ----
     /// Returns an error in case of malformed sequences in the `bytes`.
     pub fn decode<'b>(&self, bytes: &'b [u8]) -> Result<Cow<'b, str>> {
-        decode(bytes, self.encoding)
+        #[cfg(not(feature = "encoding"))]
+        let decoded = Ok(Cow::Borrowed(std::str::from_utf8(bytes)?));
+
+        #[cfg(feature = "encoding")]
+        let decoded = decode(bytes, self.encoding);
+
+        decoded
     }
 
+    /// ## Without `encoding` feature
+    ///
+    /// Decodes an UTF-8 a slice regardless of XML declaration with BOM removal
+    /// if it is present in the `bytes`.
+    ///
+    /// ## With `encoding` feature
+    ///
     /// Decodes a slice with BOM removal if it is present in the `bytes` using
     /// the reader encoding.
     ///
@@ -111,9 +103,20 @@ impl Decoder {
     ///
     /// If XML declaration is absent in the XML, UTF-8 is used.
     ///
+    /// ----
     /// Returns an error in case of malformed sequences in the `bytes`.
     pub fn decode_with_bom_removal<'b>(&self, bytes: &'b [u8]) -> Result<Cow<'b, str>> {
-        self.decode(remove_bom(bytes, self.encoding))
+        #[cfg(not(feature = "encoding"))]
+        let without_bom = if bytes.starts_with(UTF8_BOM) {
+            &bytes[3..]
+        } else {
+            bytes
+        };
+
+        #[cfg(feature = "encoding")]
+        let without_bom = remove_bom(bytes, self.encoding);
+
+        self.decode(without_bom)
     }
 }