Apply suggestions from code review

Co-authored-by: Daniel Alley <dalley@redhat.com>

src/events/attributes.rs

@@ -355,7 +355,7 @@ impl<'a> FusedIterator for Attributes<'a> {}
 /// next attribute will be attempted.
 #[derive(Debug, PartialEq)]
 pub enum AttrError {
-    /// Attribute key not followed by with `=`, position relative to start of
+    /// Attribute key was not followed by `=`, position relative to the start of the
     /// owning tag is provided.
     ///
     /// Example of input that raises this error:
@@ -365,9 +365,9 @@ pub enum AttrError {
     /// <!--     ^~~ error position, recovery position (8) -->
     /// ```
     ///
-    /// That error can be raised only if iterator in XML mode.
+    /// This error can be raised only when the iterator is in XML mode.
     ExpectedEq(usize),
-    /// Attribute value not found after `=`, position relative to start of owning
+    /// Attribute value was not found after `=`, position relative to the start of the owning
     /// tag is provided.
     ///
     /// Example of input that raises this error:
@@ -377,7 +377,7 @@ pub enum AttrError {
     /// <!--       ^~~ error position, recovery position (10) -->
     /// ```
     ///
-    /// Notice, that this error can be returned only for the last attribute in
+    /// This error can be returned only for the last attribute in
     /// the list, because otherwise any content after `=` will be threated as
     /// a value. The XML
     ///
@@ -387,11 +387,11 @@ pub enum AttrError {
     /// <!--                   '~~ error position (22) -->
     /// ```
     ///
-    /// will be threated as `Attribute { key = b"key", value = b"another-key" }`
+    /// will be treated as `Attribute { key = b"key", value = b"another-key" }`
     /// and or [`Attribute`] is returned, or [`AttrError::UnquotedValue`] is raised,
     /// depending on the parsing mode.
     ExpectedValue(usize),
-    /// Attribute value not quoted, position relative to start of owning tag
+    /// Attribute value is not quoted, position relative to the start of the owning tag
     /// is provided.
     ///
     /// Example of input that raises this error:
@@ -402,9 +402,9 @@ pub enum AttrError {
     /// <!--       '~~ error position (10) -->
     /// ```
     ///
-    /// That error can be raised only if iterator in XML mode.
+    /// This error can be raised only when the iterator is in XML mode.
     UnquotedValue(usize),
-    /// Attribute value not finished with a matching quote, position relative to
+    /// Attribute value was not finished with a matching quote, position relative to the
     /// start of owning tag and a quote is provided. That position is always a last
     /// character in the tag content.
     ///
@@ -416,12 +416,12 @@ pub enum AttrError {
     /// <!--               ^~~ error position, recovery position (18) -->
     /// ```
     ///
-    /// Notice, that this error can be returned only for the last attribute in
+    /// This error can be returned only for the last attribute in
     /// the list, because all input was consumed during scanning for a quote.
     ExpectedQuote(usize, u8),
-    /// Attribute key with the same name already was defined. Two parameters
-    /// defines the positions relative to start of owning tag for a new attribute
-    /// (error position) and a previous start position of attribute with the same
+    /// An attribute with the same name was already encountered. Two parameters
+    /// define (1) the error position relative to the start of the owning tag for a new attribute
+    /// and (2) the start position of a previously encountered attribute with the same
     /// name.
     ///
     /// Example of input that raises this error:
@@ -433,7 +433,7 @@ pub enum AttrError {
     /// <!-- '~~ previous position (4) -->
     /// ```
     ///
-    /// Notice, that this error returned only if [`Attributes::with_checks()`]
+    /// This error is returned only when [`Attributes::with_checks()`] is set to `true`
     /// was set to `true` (that is default behavior).
     Duplicated(usize, usize),
 }