fix(eslint-plugin): isTypeReadonly stack overflow (typescript-eslint#…

…4476)
MillerSvt · Oct 23, 2022 · c924f43 · c924f43
1 parent d14591c
commit c924f43
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/packages/eslint-plugin/tests/rules/prefer-readonly-parameter-types.test.ts b/packages/eslint-plugin/tests/rules/prefer-readonly-parameter-types.test.ts
@@ -1,10 +1,12 @@
 import type { TSESLint } from '@typescript-eslint/utils';
+import * as a from 'a';
 
 import rule from '../../src/rules/prefer-readonly-parameter-types';
 import type {
   InferMessageIdsTypeFromRule,
   InferOptionsTypeFromRule,
 } from '../../src/util';
+import * as util from '../../src/util';
 import { getFixturesRootDir, noFormat, RuleTester } from '../RuleTester';
 
 type MessageIds = InferMessageIdsTypeFromRule<typeof rule>;
@@ -362,6 +364,23 @@ ruleTester.run('prefer-readonly-parameter-types', rule, {
         },
       ],
     },
+    {
+      name: 'circular readonly types (Bug: #4476)',
+      code: `
+        interface Obj {
+          readonly [K: string]: Obj;
+        }
+        
+        function foo(event: Obj): void {}
+      `,
+      options: [
+        {
+          checkParameterProperties: true,
+          ignoreInferredTypes: false,
+          ...util.readonlynessOptionsDefaults,
+        },
+      ],
+    },
   ],
   invalid: [
     // arrays

diff --git a/packages/type-utils/src/isTypeReadonly.ts b/packages/type-utils/src/isTypeReadonly.ts
@@ -113,6 +113,10 @@ function isTypeReadonlyObject(
         return Readonlyness.Mutable;
       }
 
+      if (indexInfo.type === type) {
+        return Readonlyness.Readonly;
+      }
+
       return isTypeReadonlyRecurser(
         checker,
         indexInfo.type,