Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document new variable PSApplicationOutputEncoding #10876

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jborean93
Copy link
Contributor

@jborean93 jborean93 commented Feb 14, 2024

PR Summary

Documents the new variable $PSApplicationOutputEncoding which is used to control the encoding PowerShell uses when reading output from an external application.

This also removes the example for $OutputEncoding as it is wrong. The $OutputEncoding variable is only used as the encoding that PowerShell writes data through the external application's stdin pipe. The command line is always a string on Windows/Linux/macOS so is unaffected by this option.

PR Checklist

  • Descriptive Title: This PR's title is a synopsis of the changes it proposes.
  • Summary: This PR's summary describes the scope and intent of the change.
  • Contributor's Guide: I have read the contributors guide.
  • Style: This PR adheres to the style guide.

This comment was marked as outdated.

This comment was marked as outdated.

@jborean93
Copy link
Contributor Author

jborean93 commented Feb 14, 2024

Depending on what happens with #10877, I might just revert the changes to $OutputEncoding here in favour of that PR and keep this focused on the new proposed variable.

Edit: PR has been merged so I've rebased the changes here.

@sdwheeler sdwheeler added hold-for-pr Waiting - for PR merge hold-for-release Waiting - for next release labels Feb 14, 2024

This comment was marked as outdated.

This comment was marked as outdated.

@sdwheeler sdwheeler force-pushed the PSApplicationOutputEncoding branch from bfb0a36 to 49de1d1 Compare March 2, 2024 15:40

This comment was marked as outdated.

This comment was marked as outdated.

@sdwheeler sdwheeler added this to the Future milestone May 9, 2024
Documents the new variable $PSApplicationOutputEncoding which is used to
control the encoding PowerShell uses when reading output from an
external application.
@sdwheeler sdwheeler force-pushed the PSApplicationOutputEncoding branch from 49de1d1 to 823964e Compare May 16, 2024 20:17
Copy link
Contributor

Learn Build status updates of commit 823964e:

✅ Validation status: passed

File Status Preview URL Details
reference/7.5/Microsoft.PowerShell.Core/About/about_Character_Encoding.md ✅Succeeded View (powershell-7.5)
reference/7.5/Microsoft.PowerShell.Core/About/about_Preference_Variables.md ✅Succeeded View (powershell-7.5)

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hold-for-pr Waiting - for PR merge hold-for-release Waiting - for next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants