Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to pre-3.9 behavior, update version to 1.13.0 #109

Merged
merged 5 commits into from May 13, 2020

Conversation

DanielRosenwasser
Copy link
Member

@DanielRosenwasser DanielRosenwasser commented May 13, 2020

Fixes #105
Fixes #106

Here's the plan with this PR:

  • Republish 1.11.2 as 1.13.0: this unbreaks people who haven't upgraded to TypeScript 3.9
  • Publish 1.12.0 as 2.0.0: this means TypeScript 3.9 won't work on anything older than tslib 2.0

@imhoffd
Copy link

imhoffd commented May 13, 2020

Will projects that want to use TypeScript 3.9 have to wait for transitive dependencies to also be updated to tslib 2.0?

@DanielRosenwasser DanielRosenwasser merged commit b7e9c51 into master May 13, 2020
@DanielRosenwasser DanielRosenwasser deleted the revert3.9Changes branch May 13, 2020 22:53
@weswigham
Copy link
Member

Will projects that want to use TypeScript 3.9 have to wait for transitive dependencies to also be updated to tslib 2.0?

Naw, with the minor we just published, the latest tslib 1.X should be compatible with TS 3.9, but not provide live bindings, so should also be compatible with emit from TS <3.9, while the 2.X version we're about to publish should be equivalent to the 1.12 we published, and will need TS 3.9+ output to function. So long as you and your dependencies declare at least the major version they depend on, everything should be fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keywords const in tslib.es6.js
4 participants