Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle browserify-ignored module result for etw logger #33225

Merged
merged 1 commit into from Sep 4, 2019

Conversation

weswigham
Copy link
Member

Fixes #33224

@weswigham
Copy link
Member Author

weswigham commented Sep 3, 2019

cc @DanielRosenwasser we'll need to port this patch to 3.6 to fix browserifying TS 3.6

@DanielRosenwasser
Copy link
Member

Tell the bot, that's what they're here for! 😁

@weswigham
Copy link
Member Author

Hey, I just wanted you to know before we cut a release @DanielRosenwasser

@typescript-bot cherry-pick this into release-3.6

typescript-bot pushed a commit to typescript-bot/TypeScript that referenced this pull request Sep 3, 2019
Component commits:
541e96e Handle browserify-ignored module result for etw logger
@typescript-bot
Copy link
Collaborator

Hey @weswigham, I've opened #33226 for you.

@weswigham
Copy link
Member Author

@DanielRosenwasser wanna actually 👍 this?

@AviVahl
Copy link

AviVahl commented Sep 4, 2019

@weswigham while at it, mind also adding "source-map-support": false to the "browser" field of package.json? this would make typescript bundle with webpack as well. the line requiring this library is inside a try/catch, so it's safe.

I could open an issue though, if you want that issue addressed separately.

@weswigham
Copy link
Member Author

Feel free to open - I didn't realize we required that outside the test harness.

@sandersn sandersn added this to the TypeScript 3.6.3 milestone Sep 4, 2019
@weswigham weswigham merged commit f8f8876 into microsoft:master Sep 4, 2019
@weswigham weswigham deleted the check-for-member-browserify branch September 4, 2019 18:44
weswigham pushed a commit that referenced this pull request Sep 4, 2019
Component commits:
541e96e Handle browserify-ignored module result for etw logger
timsuchanek pushed a commit to timsuchanek/TypeScript that referenced this pull request Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browserify require('typescript) error on windows
6 participants