Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path tracking on value arguments #154

Merged
merged 1 commit into from Sep 5, 2022
Merged

Conversation

itchyny
Copy link
Collaborator

@itchyny itchyny commented Sep 4, 2022

I received a bug report to gojq (itchyny/gojq#186). This bug is reproducible in xq as well. I fixed the bug.

 $ xq -n 'def f($x): .y; path(f(.x))'
[
  "x",
  "y"
]
 $ jq -n 'def f($x): .y; path(f(.x))'
[
  "y"
]

@MiSawa
Copy link
Owner

MiSawa commented Sep 5, 2022

Ah hmmm, I think I don't fully understand the semantic of path, but what jq does should be correct I guess. Thank you for porting the fix!
Merging with a belief that this didn't cause the CI/tidy failure and #155 resolved it.

@MiSawa MiSawa merged commit a0ad282 into master Sep 5, 2022
@itchyny itchyny deleted the fix-path-value-argument branch September 5, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants