[TM-5984] Maintain Assignments Remediation #2982
Conversation
| tod_months_num: todMonths || null, | ||
| tod_other_text: todOther || null, | ||
| tod_adjust_months_num: null, |
There was a problem hiding this comment.
this all looks familiar ... i think you have it right 🤔
i have some API code commented that says # only custom/other TOD should have months and other_text meaning, that the tod_months and tod_other_text values don't get sent to the frontend (in that specific section) UNLESS, the TOD is 'other,' and then the same the other way around (so only send months & other_text if TOD is 'other')
hope that makes sense lol - this looks right to me
| if (isNew) { | ||
| /* eslint-disable quote-props */ | ||
| sections.subheading = [ | ||
| { 'Position Number': pos_results?.pos_num_text || NO_POSITION_NUMBER }, | ||
| { 'Position Title': pos_results?.pos_title_desc || NO_POSITION_TITLE }, | ||
| { 'Bureau': pos_results?.pos_bureau_short_desc || NO_BUREAU }, | ||
| { 'Location': pos_results?.pos_location_code || NO_POST }, | ||
| { 'Org': pos_results?.pos_org_short_desc || NO_ORG }, | ||
| { 'Grade': pos_results?.pos_grade_code || NO_GRADE }, | ||
| { 'Pay Plan': pos_results?.pos_pay_plan_code || NO_GRADE }, | ||
| ]; | ||
| /* eslint-enable quote-props */ | ||
| } |
There was a problem hiding this comment.
I originally had this in the useEffect bc it wouldn't render changes on different pos num searches. It works fine without it now, did I miss something from an earlier change that would track pos_results changes? Or is it automatic re-renders from useSelector and I'm just dumb?
|
Noticed Disabled inputs - is that aligned with FSBID currently? |
Changes:
Dual Merge:
TM-5984